Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balance testing #130

Merged
merged 13 commits into from
Jun 24, 2024
Merged

balance testing #130

merged 13 commits into from
Jun 24, 2024

Conversation

mixmix
Copy link
Contributor

@mixmix mixmix commented Jun 20, 2024

WIP

Depends on : entropyxyz/sdk#389

closes #121

@mixmix mixmix marked this pull request as draft June 20, 2024 04:08
@mixmix mixmix changed the base branch from main to dev June 20, 2024 04:09
@mixmix
Copy link
Contributor Author

mixmix commented Jun 20, 2024

@rh0delta if you yarn link in that associated SDK PR ... then try to run the tests you will see:

yarn run v1.22.1
$ yarn test:types && yarn test:ts && yarn test:only
$ tsc --project tsconfig.json
tests/balance.test.ts:4:21 - error TS2307: Cannot find module '@entropyxyz/sdk/keys' or its corresponding type declarations.

4 import Keyring from '@entropyxyz/sdk/keys'
                      ~~~~~~~~~~~~~~~~~~~~~~

tests/testing-utils/index.ts:1:49 - error TS2307: Cannot find module '@entropyxyz/sdk/dev/testing-utils.mjs' or its corresponding type declarations.

1 import { spinNetworkUp, spinNetworkDown, } from "@entropyxyz/sdk/dev/testing-utils.mjs"
                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


I think the problem is our moduleResoltion in tsconfig .... like it's set to some old value node when it should be something newer? I dunno, it's a nightmare
https://stackoverflow.com/questions/70296652/how-can-i-use-exports-in-package-json-for-nested-submodules-and-typescript

@rh0delta rh0delta marked this pull request as ready for review June 21, 2024 20:34
@rh0delta
Copy link
Contributor

@rh0delta if you yarn link in that associated SDK PR ... then try to run the tests you will see:

yarn run v1.22.1
$ yarn test:types && yarn test:ts && yarn test:only
$ tsc --project tsconfig.json
tests/balance.test.ts:4:21 - error TS2307: Cannot find module '@entropyxyz/sdk/keys' or its corresponding type declarations.

4 import Keyring from '@entropyxyz/sdk/keys'
                      ~~~~~~~~~~~~~~~~~~~~~~

tests/testing-utils/index.ts:1:49 - error TS2307: Cannot find module '@entropyxyz/sdk/dev/testing-utils.mjs' or its corresponding type declarations.

1 import { spinNetworkUp, spinNetworkDown, } from "@entropyxyz/sdk/dev/testing-utils.mjs"
                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I think the problem is our moduleResoltion in tsconfig .... like it's set to some old value node when it should be something newer? I dunno, it's a nightmare https://stackoverflow.com/questions/70296652/how-can-i-use-exports-in-package-json-for-nested-submodules-and-typescript

this has been fixed with edits made in the connected PR on the sdk repo entropyxyz/sdk#389

@rh0delta rh0delta requested a review from frankiebee June 21, 2024 20:35
Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just commit my suggestions they docs @rh0delta

src/common/initializeEntropy.ts Show resolved Hide resolved
src/common/initializeEntropy.ts Show resolved Hide resolved
src/common/initializeEntropy.ts Show resolved Hide resolved
rh0delta and others added 3 commits June 21, 2024 17:47
Co-authored-by: Frankie <frankie.diamond@gmail.com>
Co-authored-by: Frankie <frankie.diamond@gmail.com>
@rh0delta rh0delta requested a review from frankiebee June 24, 2024 14:25
Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOOOO! tests!

@frankiebee frankiebee merged commit 47ae2ca into dev Jun 24, 2024
1 check passed
@frankiebee frankiebee deleted the naynay/balance-testing branch June 24, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants